This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
fix makefile to read variables from environment and overrides #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
wild-endeavor
approved these changes
Apr 12, 2023
pradithya
pushed a commit
to pradithya/flytepropeller
that referenced
this pull request
Apr 18, 2023
…rg#554) Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com>
hamersaw
added a commit
that referenced
this pull request
Apr 19, 2023
…ng Vault Secret Manager (#556) * Implement ability to specify additional annotations when using Vault secret manager Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Infer GOOS and GOARCH from environment (#552) Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * fix makefile to read variables from environment and overrides (#554) Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Remove BarrierTick (#545) * removed barrier logic Signed-off-by: Daniel Rammer <daniel@union.ai> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <daniel@union.ai> * removed barrier tests Signed-off-by: Daniel Rammer <daniel@union.ai> * bumping flyteplugins Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Check for TerminateExecution error and eat Precondition status (#553) * Check for TerminateExecution error and eat Precondition status Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Rename to annotation Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Inline merging annotations Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> --------- Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Dan Rammer <daniel@union.ai> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…rg#554) Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…ng Vault Secret Manager (flyteorg#556) * Implement ability to specify additional annotations when using Vault secret manager Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Infer GOOS and GOARCH from environment (flyteorg#552) Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * fix makefile to read variables from environment and overrides (flyteorg#554) Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Remove BarrierTick (flyteorg#545) * removed barrier logic Signed-off-by: Daniel Rammer <daniel@union.ai> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <daniel@union.ai> * removed barrier tests Signed-off-by: Daniel Rammer <daniel@union.ai> * bumping flyteplugins Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Check for TerminateExecution error and eat Precondition status (flyteorg#553) * Check for TerminateExecution error and eat Precondition status Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Rename to annotation Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> * Inline merging annotations Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> --------- Signed-off-by: Pradithya Aria <pradithya.pura@go-jek.com> Signed-off-by: Jeev B <jeevb@users.noreply.github.com> Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Dan Rammer <daniel@union.ai> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.