Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support for Dial events for SD+ #54

Open
mmanciop opened this issue Jan 30, 2024 · 2 comments
Open

Feature Request: support for Dial events for SD+ #54

mmanciop opened this issue Jan 30, 2024 · 2 comments

Comments

@mmanciop
Copy link

Description

The Elgato Streamdeck SDK exposes dial-specific hooks in their version of Action:

/**
 * Registers a callback function for the onDialRotate event, which fires when a SD+ dial was rotated
 * @param {function} fn
 */
onDialRotate(fn) {

}

/**
 * Registers a callback function for the dialPress event, which fires when a SD+ dial was pressed or released
 * @deprecated Use onDialUp and onDialDown instead
 */
onDialPress(fn) {

}

/**
 * Registers a callback function for the dialDown event, which fires when a SD+ dial was pressed
 * @param {function} fn
 */
onDialDown(fn) {

}

/**
 * Registers a callback function for the dialUp event, which fires when a pressed SD+ dial was released
 * @param {function} fn
 */
onDialUp(fn) {

}

I'd love for similar capabilities to be part of this library.

Describe the solution

I could envision an extension of Action (or a type that both Action and the new type extend) that is focused on dial-related action. That way, the library would not break the contract for "normal" actions, while allowing the development of Dial specific actions, which are very underrepresented in the marketplace (for example, I found no way of execution commands from a dial).

Alternatives you considered

Hacking terrible, terrible things.

@fnando
Copy link
Owner

fnando commented Jan 30, 2024

There is #44, but it needs some love. I don't have a StreamDeck with a dial, so I can't really test it out and push it to the finish line.

@mmanciop
Copy link
Author

mmanciop commented Jan 30, 2024

There is #44, but it needs some love. I don't have a StreamDeck with a dial, so I can't really test it out and push it to the finish line.

As the issue suggests, I have one, and while I am new to StreamDeck plugins and likely will need a bit of handholding, I could see myself working on landing that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants