Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considereing isssues with Sedna to be fixed, can you use something like Architectury (for Forge and Fabric)? #286

Open
ajh123 opened this issue Apr 27, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@ajh123
Copy link

ajh123 commented Apr 27, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

It would be hard for you to maintain two separate branches for a Fabric and one for Forge. Since you need to update to newer Minecraft versions this is a good reason to switch to using Architectury.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Migrate to Architectury. Architectury allows you to have one loader independent "common folder" for code that is the same across versions and have multiple "folders" for each loader. Each loader specific "folder" will have code that will be used for starting up the mod. This means about 90% of the mod will be inside the "common folder" which will make it easier to maintain two separate versions because they are the same.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Some people have problems with the Architectury API, however Architectury can be used without the Architectury API, for example you could use Registrate and Porting Lib instead (these are what Create uses and my own mod). https://github.com/Fabricators-of-Create/create-multiloader-addon-template/tree/1.20.1 is a template which shows you how to do this.

Additional context
Add any other context or screenshots about the feature request here.

fnuecke/sedna#19 looks like good progress.

@ajh123 ajh123 added the enhancement New feature or request label Apr 27, 2024
@lucsoft
Copy link
Contributor

lucsoft commented Apr 27, 2024

I would also enjoy Architectury instead of two separate code branches

@atirut-w
Copy link

atirut-w commented Apr 27, 2024

I'm hugely in favor of this, considering that it reduces maintenance cost a lot by having common codes in a single branch.

@fnuecke
Copy link
Owner

fnuecke commented Apr 27, 2024

Yes, this is indeed my plan; I had started this way back when I was last active on this project, but lost traction due to some things using specifics of Forge if I remember correctly. Since then I've migrated my other smaller mods to Architectury and feel pretty at home with it. I plan on picking the porting effort back up soon.

(Semi-related, since linked above, I have already pushed an update to the library mod with the virtual page access fix.)

@ajh123
Copy link
Author

ajh123 commented Apr 27, 2024

@fnuecke That's excellent news. Do we have an estimation when soon is?

@lucsoft
Copy link
Contributor

lucsoft commented Apr 27, 2024

@fnuecke maybe just push it somewhere here maybe we can help port it together?

@lucsoft
Copy link
Contributor

lucsoft commented Apr 27, 2024

I also tried to update current branch to more modern version and found out some core parts got replaced with vanilla like patterns

@ajh123
Copy link
Author

ajh123 commented Jul 17, 2024

There is https://github.com/North-Western-Development/oc2r which is a continuation of oc2 but ported to modern Minecraft. On their Curseforge page they say they are planning to use Architectury however no code have been made so far.

However, since they have already ported to modern Minecraft it would be a lot easier to port to Architectury by using their code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants