Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression #5

Closed
3 tasks done
distantcam opened this issue Feb 19, 2013 · 7 comments
Closed
3 tasks done

Compression #5

distantcam opened this issue Feb 19, 2013 · 7 comments

Comments

@distantcam
Copy link
Member

This features compresses the files before embedding them, and uncompresses them automatically right before use.

I've got this working in my own branch, but I'd still like to add a few features and discuss it before pushing to main.

  • Compressing of auto-embedded resources.
  • Updated loaders to read compressed resources.
  • Config option to turn off compression completely.
  • [ ] Config option to turn off compression per assembly.
@distantcam
Copy link
Member Author

First question, should compression be on or off by default?

Second, how should the per assembly config work? Flip the default or specify it explicitly as an override?

@SimonCropp
Copy link
Member

why would you want to config per assembly?

@distantcam
Copy link
Member Author

Just covering the bases. So you think it won't be needed?

@SimonCropp
Copy link
Member

Just cant think of a case that people would only compress some assemblies.
The only thing is some very small files dont get much out of compression. but modern compression algorithms take this into account so not our problem

@SimonCropp
Copy link
Member

BTW what r u using for compression

@distantcam
Copy link
Member Author

Just DeflateStream. I've used it before and it's fine. Quick enough to not have a noticeable speed hit.

@distantcam
Copy link
Member Author

Pull request #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants