Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costura not updating fodyweavers.xml correctly #9

Closed
GeertvanHorrik opened this issue Apr 8, 2013 · 6 comments
Closed

Costura not updating fodyweavers.xml correctly #9

GeertvanHorrik opened this issue Apr 8, 2013 · 6 comments

Comments

@GeertvanHorrik
Copy link
Member

I was installing it to an existing project which already had a few weavers. Then VS suddently asked me: do you want to overwrite FodyWeavers.xml?

It seemed that it created a brand new fodyweavers.xml instead of adding the weaver to the existing list of weavers.

@SimonCropp
Copy link
Member

do you have the latest nuget beta installed?

@distantcam
Copy link
Member

I had the same thing happen with PropertyChanged. Because I was using a custom event name upgrading to a new version of PropertyChanged nuked that setting in fodyweavers.xml.

I suspect this might be an issue when switching from the plugin version of fody to the nuget version.

@SimonCropp
Copy link
Member

that could make sense.
With the pre nuget fody "fodyweavers.xml" was injected with powershell.
So moving from the VSIX fody to the nuget fody could cause a loss of the fodyweavers.xml contents

The question is "is this worth fixing"?

@distantcam
Copy link
Member

Hmmm. I don't know.

How many support hassles is it causing you?

Does this only happen when going from pre-nuget to nuget fody? Are we sure it doesn't happen when going from version to version of nuget fody?

@SimonCropp
Copy link
Member

unless anyone objects I am going to close this as "not worth fixing"

@GeertvanHorrik
Copy link
Member Author

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants