This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
add a method to IPAddr instead of breaking a useful one #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ecloud was extracted, it didn't bring over this patch from base fog: fog/fog@7a2719f fog/fog#907 > @jnewland wrote: > The monkey patch to IPAddr#mask in the ecloud compute provider unnecessarily removes functionality from IPAddr in both 1.8.7 and 1.9. This pull request adds a method to IPAddr instead of breaking a useful one.
plribeiro3000
added a commit
that referenced
this pull request
Apr 6, 2015
add a method to IPAddr instead of breaking a useful one
|
@jrafanie Thanks! |
|
@plribeiro3000 Thanks! Can you release a new version? Just adding require 'fog' to any of our non-fog based tests that were using IPAddr#mask were failing with 1 for 0 errors... Thanks again! |
|
Wow, you did already! Thanks @plribeiro3000 👍 |
|
Done. Released as I was on it when you asked. :p EDIT: Thanks you for the patch! |
|
@plribeiro3000 I was pairing with @Fryguy on this and he spotted the problem when we were looking at the 0.0.2 -> 0.1.0 diff. Thanks for the fast turnaround! |
|
thanks for the great turn around all |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ecloud was extracted, it didn't bring over this patch from base fog:
fog/fog@7a2719f
fog/fog#907