Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for merge and release permissions #118

Closed
ares opened this issue Jun 15, 2022 · 8 comments
Closed

Ask for merge and release permissions #118

ares opened this issue Jun 15, 2022 · 8 comments

Comments

@ares
Copy link
Contributor

ares commented Jun 15, 2022

A set of issues was reported on Foreman project with recent version of libvirt. Some have even fixing PRs here, e.g. #116

I know this gem was maintained more actively, but I suppose it falls under similar category as other adapters, @geemus if you wouldn't object, we'd like to get merge permissions and release ownership on rubygems so we could restore the compatibility with the new version of libvirt. That means, we would not actively develop the gem, but we'd try to maintain it, since it's Foreman project dependency.

Thanks for considering.

@ares ares changed the title needs merge and release permissions Ask for merge and release permissions Jun 15, 2022
@ekohl
Copy link
Contributor

ekohl commented Jun 15, 2022

Both I and @lzap already have commit/merge access on this gem but do not have the permissions to release.

@geemus
Copy link
Member

geemus commented Jun 17, 2022

Yes, I think that sounds reasonable. I think I just need your Rubygems associated email addresses.

Could share them with me by email (it's my username at gmail) so you all don't have to post them here?

Thanks.

@ekohl
Copy link
Contributor

ekohl commented Jun 20, 2022

I've sent you an email, also with the request to add https://rubygems.org/profiles/theforeman so the Foreman project admins have a fallback. Relying on individuals can be tricky. The only downside is that that account has no 2FA.

@geemus
Copy link
Member

geemus commented Jun 21, 2022

@ekohl Great, thanks. I've invited both as owners, so I think they should work once confirmed.

@ekohl
Copy link
Contributor

ekohl commented Jun 21, 2022

I see both icons on https://rubygems.org/gems/fog-libvirt so I think we can close this out. Thanks!

@ekohl ekohl closed this as completed Jun 21, 2022
@ares
Copy link
Contributor Author

ares commented Jun 21, 2022

Thank you @geemus!

@electrofelix
Copy link
Contributor

@ekohl does this mean a new release will be forthcoming? There is a fix merged since the last release that would be nice to see in a release as it will fix the destroy behaviour when nvram is enabled for vagrant-libvirt vagrant-libvirt/vagrant-libvirt#1371

@ekohl
Copy link
Contributor

ekohl commented Dec 1, 2022

I released all open changes since 0.9.0 and released 0.10.0: https://rubygems.org/gems/fog-libvirt/versions/0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants