-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openstack] add block_device_mapping_v2 #3071
[openstack] add block_device_mapping_v2 #3071
Conversation
@mwhagedorn could you review? Thanks! |
@geemus.. will do
|
@geemus @mwhagedorn How about this PR? |
@mdarby @smashwilson - could one of you review? Thanks! |
:uuid => cinder_uddi, | ||
:boot_index => 0 | ||
] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄 The indentation here is rather un-Ruby-like, and (in my opinion) obscures the structure somewhat. Also, you're missing a hash inside the :block_device_mapping_v2
array, and technically :image_ref
is required, too. How about:
vm = compute_client.servers.create(
:name => name,
:flavor_ref => flavor,
:image_ref => image,
:block_device_mapping_v2 => [
{
:device_name => "/dev/sda1",
:source_type => "volume",
:destination_type => "volume",
:delete_on_termination => false,
:uuid => cinder_uddi,
:boot_index => 0
}
]
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I was again as pointed out .
@smashwilson Please review, I have fixed it. |
@geemus How about this PR? |
👍 |
Thanks! |
…mapping_v2 [openstack] add block_device_mapping_v2
fix block_device_mapping_v2
http://docs.openstack.org/api/openstack-compute/2/content/POST_block_device_mapping_v2_createServer__v2__tenant_id__servers_ext-os-block-device-mapping-v2-boot.html