Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openstack] add block_device_mapping_v2 #3071

Merged
merged 3 commits into from
Nov 23, 2014
Merged

[openstack] add block_device_mapping_v2 #3071

merged 3 commits into from
Nov 23, 2014

Conversation

@tnaoto tnaoto changed the title fix block_device_mapping_v2 [openstack] fix block_device_mapping_v2 Jul 24, 2014
@geemus
Copy link
Member

geemus commented Jul 24, 2014

@mwhagedorn could you review? Thanks!

@mwhagedorn
Copy link
Contributor

@geemus.. will do
On Jul 24, 2014, at 12:53 PM, Wesley Beary notifications@github.com wrote:

@mwhagedorn could you review? Thanks!


Reply to this email directly or view it on GitHub.

@tnaoto tnaoto changed the title [openstack] fix block_device_mapping_v2 [openstack] add block_device_mapping_v2 Nov 14, 2014
@tnaoto
Copy link
Contributor Author

tnaoto commented Nov 14, 2014

@geemus @mwhagedorn
Hello!
I change this PR.
[block_device_mapping] "and" [block_device_mapping_v2]

How about this PR?

@geemus
Copy link
Member

geemus commented Nov 14, 2014

@mdarby @smashwilson - could one of you review? Thanks!

:uuid => cinder_uddi,
:boot_index => 0
]
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 The indentation here is rather un-Ruby-like, and (in my opinion) obscures the structure somewhat. Also, you're missing a hash inside the :block_device_mapping_v2 array, and technically :image_ref is required, too. How about:

vm = compute_client.servers.create(
  :name => name,
  :flavor_ref => flavor,
  :image_ref => image,
  :block_device_mapping_v2 => [
    {
      :device_name => "/dev/sda1",
      :source_type => "volume",
      :destination_type => "volume",
      :delete_on_termination => false,
      :uuid => cinder_uddi,
      :boot_index => 0
    }
  ]
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I was again as pointed out .

@tnaoto
Copy link
Contributor Author

tnaoto commented Nov 17, 2014

@smashwilson Please review, I have fixed it.

@tnaoto
Copy link
Contributor Author

tnaoto commented Nov 22, 2014

@geemus How about this PR?

@mdarby
Copy link

mdarby commented Nov 22, 2014

👍

@geemus
Copy link
Member

geemus commented Nov 23, 2014

Thanks!

geemus added a commit that referenced this pull request Nov 23, 2014
…mapping_v2

[openstack] add block_device_mapping_v2
@geemus geemus merged commit 620a875 into fog:master Nov 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants