New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landed all my changes #8

Closed

scottchiefbaker opened this issue Feb 21, 2014 · 1 comment

Collaborator

scottchiefbaker commented Feb 21, 2014

I took a serious rebase and some hand-holding but I was able to land all my changes on to yours. Couple of things

As part of the rebase I opted to NOT convert to tabs (I excluded that commit). I also added a Vim modeline at the bottom so other vim users will contribute the same way
Line #128 and #129 of Server.php I changed slighly to reflect the error level of the calling script. Not 100% if that's what we want. I'm open for discussion on that.
It passes all my internal tests

Take a look and let me know what you think.

Collaborator Author

scottchiefbaker commented Feb 11, 2015

This is old an not appropriate anymore

scottchiefbaker closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment