Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for platform instead of system #63

Closed
fohrloop opened this issue Oct 26, 2023 · 0 comments · Fixed by #98
Closed

Check for platform instead of system #63

fohrloop opened this issue Oct 26, 2023 · 0 comments · Fixed by #98
Assignees
Milestone

Comments

@fohrloop
Copy link
Owner

The current implementation has three systems:

  • windows
  • linux
  • darwin

These are all actually just directly platform.system().lower().

Might be better the change the name to be "platform" as python might be running on WSL or Cygwin on Windows..? Not yet sure if these two can be supported but at least is should be possible to detect that wakepy is running on WSL/Cygwin.

Task:

  • Replace the SystemName with PlatformName class (or just platform module with constants WINDOWS, LINUX, and MACOS)
  • Create function which can detect these platforms: Windows, Linux, MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant