Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes install does not honor dependencies OKAPI-925 #1009

Merged

Conversation

adamdickmeiss
Copy link
Contributor

But needs a good test for it.

@adamdickmeiss adamdickmeiss marked this pull request as draft October 21, 2020 17:26
@adamdickmeiss adamdickmeiss marked this pull request as ready for review October 22, 2020 09:06
@adamdickmeiss
Copy link
Contributor Author

adamdickmeiss commented Oct 22, 2020

The List<String> ret .. is a bit misleading.. Should probably be called List<String> errors or something.. But I'd rather keep this PR not too big and refactor tests and the implementation later in master only.

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@adamdickmeiss adamdickmeiss merged commit d8d7266 into master Oct 22, 2020
@adamdickmeiss adamdickmeiss deleted the OKAPI-925-install-does-not-honor-specified-modules-ids branch October 22, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants