Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with text-rendering-tests #49

Closed
brawer opened this issue Sep 26, 2016 · 4 comments
Closed

Test with text-rendering-tests #49

brawer opened this issue Sep 26, 2016 · 4 comments

Comments

@brawer
Copy link

brawer commented Sep 26, 2016

Hi Devon, just fyi, the text rendering test suite (the one that was previously in my GitHub space) has now moved to Unicode: https://github.com/icu-project/text-rendering-tests — feel free to use it for testing fontkit. Also, if you’d like to contribute to the test suite, your contributions would be very welcome — I’ll send you the Unicode CLA if you’re interested.

@devongovett
Copy link
Member

Cool thanks @brawer. I actually already had a fork with fontkit support. I will update it to the latest version. https://github.com/devongovett/fonttest/tree/fontkit

@brawer
Copy link
Author

brawer commented Sep 26, 2016

Great; attaching Unicode’s CLA; if you send a scan with your signature to sascha@brawer.ch I’ll forward it to Unicode. Thanks, and looking forward to more changes...

@brawer
Copy link
Author

brawer commented May 1, 2017

The test suite now takes --engine=OpenType.js which invokes JavaScript through NPM. If you want, feel free to make a pull request similar to this one. The test report for OpenType.js doesn’t look so great yet, but they’re working on improving things; would be curious to see how fontkit looks.

@devongovett
Copy link
Member

Submitted unicode-org/text-rendering-tests#35!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants