Drop node dependencies #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Could the legacy encoding become an optional import under a node-only export map along with the streaming API? Or just provide both through a separate import available through a specific file? Still a major version breaking change but at least gives folk a fallback option and still keeps the main import clean of node dependencies easily? |
carlobeltrame
approved these changes
Jun 12, 2022
There was a problem hiding this comment.
Thanks, this is definitely a big step forward! I am currently testing it in the context of https://github.com/diegomura/react-pdf, will let you know of any issues I find.
|
@carlobeltrame thanks. Please note that this is a breaking change, so will require changes to fontkit as well. |
carlobeltrame
added a commit
to carlobeltrame/react-pdf
that referenced
this pull request
Jun 16, 2022
This will start working once foliojs/restructure#48 is merged.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
This drops Node Buffer usages, and replaces them with Uint8Array, DataView, and TextDecoder/TextEncoder, which are standard browser APIs also supported by Node.
iconv-lite usages are also dropped. Unfortunately, TextEncoder only supports utf8, while TextDecoder supports many legacy encodings. This means that decoding legacy encodings is supported with no bundle size implications, but encoding is not supported. This should be ok for fontkit but it is a breaking change.
The one remaining node API in use is streams. Web Streams unfortunately are only supported in Node 16, but Node 14 is still LTS. I suppose we could require a polyfill but that's not great...