Drop node dependencies #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires foliojs/restructure#48
This removes all node-specific dependencies from fontkit. This means usages of Buffer have been replaced with Uint8Array/TextEncoder/TextDecoder. In addition, streams have been removed. This was only used for encoding subsets. Now you call
subset.encode()rather thansubset.encodeStream()and get back a Uint8Array. The streaming API didn't really offer much benefit anyway. iconv-lite has also been dropped.There are actually 4 different builds: CommonJS and ESM for Node, as well as both for the browser as well. The difference is that the Node build includes the
fsrelated functionsopenandopenSync, whereas the browser version does not.Due to breaking changes, this will be released in a major version bump.