Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noice <> nvim-notify settings #38

Closed
entropitor opened this issue Oct 7, 2022 · 7 comments
Closed

Noice <> nvim-notify settings #38

entropitor opened this issue Oct 7, 2022 · 7 comments
Labels
invalid This doesn't seem right

Comments

@entropitor
Copy link

Describe the bug
When I set nvim-notify settings through require('notify').setup({...}) the vim.notify messages don't appear in :Noice

I use packer, in case that's relevant

Which version of Neovim are you using?
Nightly

Expected Behavior
There is a way to configure nvim-notify settings by calling notify.setup or by passing it through noice settings

@Shougo
Copy link
Contributor

Shougo commented Oct 8, 2022

Please upload your nvim-notify config. I will test it later.

@entropitor
Copy link
Author

  use({
    "rcarriga/nvim-notify",
    config = function()
      local notify = require("notify")
      notify.setup({
        render = "minimal",
        stages = "static",
        timeout = 1000,
      })
    end,
  })

@Shougo
Copy link
Contributor

Shougo commented Oct 9, 2022

スクリーンショット_2022-10-09_12-13-17
I have tested it and I don't reproduce the problem.

@folke
Copy link
Owner

folke commented Oct 9, 2022

I know what's happenig here. When we're in blovking mode, we use a separate notify instance that renders without animations. Otherwise, you would not see the notificaiton.

Will fix it so that for that instance we use the user settings as well.

@folke
Copy link
Owner

folke commented Oct 9, 2022

Actually, everything should already work as expected.

Are you still settting vim.notify = require('notify') anywhere in your init.lua?

You shouldn't do that, since that would prevent Noice from picking up Notifications

@folke folke added the invalid This doesn't seem right label Oct 9, 2022
@Shougo
Copy link
Contributor

Shougo commented Oct 9, 2022

I think noice.nvim should check vim.notify is overwritten.

@entropitor
Copy link
Author

Don't seem to be able to reproduce anymore 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants