"mode" can't be used in group mappings

[cideM]

If I try to do something like this

wk.register {
    ["<leader>f"] = {
        name = "+find",
        o = {"<Plug>(GrepperOperator)", "operator"},
        o = {"<Plug>(GrepperOperator)", "operator", mode="x"},
    },
}

the plugin complains with

Error detected while processing VimEnter Autocommands for "*":
E5108: Error executing lua .../home-manager/start/which-key-niv/lua/which-key/keys.lua:159: Invalid key mapping: { "<Plug>(GrepperOperator)"
, "operator",
  mode = "x"
}

so I need to pull the mappings apart:

wk.register({
    ["<leader>f"] = {
        o = {"<Plug>(GrepperOperator)", "operator"},
    }},{mode="x"}
)
wk.register {
    ["<leader>f"] = {
        name = "+find",
        o = {"<Plug>(GrepperOperator)", "operator"},
    },
}

which works but is a bit annoying because now there are always multiple places where I need to look for the mappings for a given group. Would you consider making mode available in group mappings too? Because things like silent and noremap work.

[folke]

Just added this. Adding mode='x' as in your example, now works as expected

[cideM]

Awesome, it did fix that issue. But I have another issue with regards to modes. I can create a new issue if you'd prefer that. I'm trying to translate

nmap gs  <plug>(GrepperOperator)
xmap gs  <plug>(GrepperOperator)

but the following config is obviously stupid because I'm just overwriting a key in a table

["<leader>f"] = {
  name = "+Find",
  o = {"<Plug>(GrepperOperator)", "string"},
  o = {"<Plug>(GrepperOperator)", "string", mode="x"},
}

results in <leader>fo only being shown in visual selection (great!) but not in normal mode (sad panda). I assume the second o overrides the first, since it doesn't account for the possibility of duplicates which are OK because they're in different modes?

EDIT: strike through to banish this rather embarassing brain freeze

[folke]

That's actually a lua table where you assign the index o twice.

So I never know there were actually two entries there.

[folke]

I'll make a change where you can set mode = {'n', 'x'}

[cideM]

That's actually a lua table where you assign the index o twice.

So I never know there were actually two entries there.

🤦 thanks

[folke]

I'll close this and leave it as it is right now. There's multiple possibilities to define the maps for multiple modes.

[kdheepak]

I was expecting this to work but it doesn't.

local mappings = {
    p = {'"+p', 'Paste from clipboard', mode = {'n', 'v'}},
    P = {'"+P', 'Paste from clipboard (before)', mode = {'n', 'v'}},
    y = {'"+y', 'Yank to clipboard', mode = {'n', 'v'}},
    Y = {'"+Y', 'Yank line to clipboard', mode = {'n', 'v'}},
}

local opts = {
    mode = "n", 
    prefix = "<leader>",
}

wk.register(mappings, opts)

Is the only way to do this define opts twice, one with mode = "n" and another with mode = "v"?

[kdheepak]

The error that I get when I try the above is this:

"lua/kdheepak/which-key.lua" 168L, 8385C
Error detected while processing VimEnter Autocommands for "*":
E5108: Error executing lua .../pack/packer/start/which-key.nvim/lua/which-key/keys.lua:251: Error executing lua: Vim:E730: using List as a String
Press ENTER or type command to continue

[AmeerTaweel]

I'll make a change where you can set mode = {'n', 'x'}

@folke any updates on this? I tried using it today, but it did not work. This is the code I tried to use:

which_key.register({
	d = { [["+d]], "delete to clipboard" },
	p = { [["+p]], "paste from clipboard" },
	P = { [["+P]], "paste from clipboard" },
	y = { [["+y]], "yank to clipboard" }
}, { prefix = "<leader>", mode = { "n", "x" } })

[hermitmaster]

I'll make a change where you can set mode = {'n', 'x'}

@folke any updates on this? I tried using it today, but it did not work. This is the code I tried to use:

which_key.register({
	d = { [["+d]], "delete to clipboard" },
	p = { [["+p]], "paste from clipboard" },
	P = { [["+P]], "paste from clipboard" },
	y = { [["+y]], "yank to clipboard" }
}, { prefix = "<leader>", mode = { "n", "x" } })

I just ran into the same issue trying to map text objects.
['ih'] = { ':<C-U>Gitsigns select_hunk<cr>', 'Select Hunk', mode = { 'o', 'x' } },

[LukasDoesDev]

Is it possible to make this work?

[afreakk]

Is it possible to make this work?

You can do it like:

    s = { "bind1", "blabla" },
    ["ss"] = { "bind2", "blabla" },