-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependents to newer versions. #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plan sounds good, thank you!
I gave up bump Poison to version 5.0. Poison has adjusted the They replaced iex(1)> Bento.decode("li1e3:twoli3eee")
** (BadMapError) expected a map, got: []
(elixir 1.14.3) lib/map.ex:534: Map.get([], :as, nil)
lib/poison/decoder.ex:21: Poison.Decode.transform/2
(bento 1.0.0-dev) lib/bento.ex:77: Bento.decode/2
iex:1: (file) If we want to upgrade to version 5.0 of Poison without breaking changes, we have to use a polyfill like: def decode(iodata, options \\ []) do
with {:ok, parsed} <- Parser.parse(iodata) do
{:ok, Poison.Decode.transform(parsed, Map.new(options))}
end
end It's too ugly to accept! So I decided to pin the version of Poison to 3.1. On the other hand, I found that we only used the function |
I forgot to implement it in PR folz#15.
* build: setup GitHub Dependabot I forgot to implement it in PR #15. * build(ci): migrate CI from Travis to GitHub Action * fix(ci): fix a formatting error See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixinclude * fix(ci): repair compatibility between Elixir & OTP See: https://hexdocs.pm/elixir/1.14.3/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp * build(ci): setup matrix for job `build` * fix(ci): fix a syntax error * docs: reset badges in README.md * build(ci): run benchmark in CI * build(ci): publish to hex.pm after git tag added TODO: Need GitHub Action Secrets: `HEX_API_KEY` * build(ci): setup GitHub Dependabot for GitHub Action * fix(ci): fix a syntax error See: https://docs.github.com/en/actions/learn-github-actions/expressions#operators * fix(ci): only run benchmark manually See: https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label * build(ci): classify PR through actions/labeler * build: run dialyzer test in CI * fix(ci): distinguish the OS version when using cache * build(ci): more refined control caching * fix(ci): deps should be needed for job test
I plan to bump dependents to newer versions. It seems that
Poison
has changed the API, so errors can occur. I will update it manually and check it one by one.Then I'm going to set up GitHub Dependabot, which automatically monitors dependencies and securely updates them.
To-do list:
(abandon, reason):poison
~> 5.0:dialyxir
~> 1.2:ex_doc
~> 0.27:credo
~> 1.6To-do list out of this pr (for tracking):
Poison.Decode.decode/2
#16