Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Correct wrong default values #134

Merged
merged 2 commits into from
Jun 16, 2019
Merged

[Progress] Correct wrong default values #134

merged 2 commits into from
Jun 16, 2019

Conversation

ryamaguchi0220
Copy link
Contributor

I corrected wrong default values in progress settings.

@ryamaguchi0220
Correct wrong default values
226254a 
I corrected wrong default values in progress settings.
@ryamaguchi0220 ryamaguchi0220 changed the title Correct wrong default values [Progress] Correct wrong default values May 30, 2019
lubber-de
lubber-de reviewed May 30, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR
Please add the missing trailing commas. Even if it's docs only we want to provide working code.
Other than that LGTM 👍

server/documents/modules/progress.html.eco Outdated Show resolved Hide resolved
@lubber-de lubber-de added the Correction Anything related to fixing incorrect documentation label May 30, 2019
exoego
exoego approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de mentioned this pull request Jun 10, 2019
Merged
@y0hami y0hami merged commit ec6fa0a into fomantic:develop Jun 16, 2019
@ryamaguchi0220 ryamaguchi0220 deleted the ryamaguchi0220-patch-1 branch June 17, 2019 09:56
@lubber-de lubber-de added this to the 2.7.7 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@y0hami y0hami Awaiting requested review from y0hami

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
Correction Anything related to fixing incorrect documentation
Projects
None yet
Milestone
2.7.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryamaguchi0220 @exoego @lubber-de @y0hami