Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): Fixed default values and missing content. #147

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

lubber-de
Copy link
Member

Description

Some popup default settings did not match the current codebase.

Based on Semantic-Org/Semantic-UI-Docs#420 and added more missing/wrong settings
Thanks to @TivoSoho

@lubber-de lubber-de added the Correction Anything related to fixing incorrect documentation label Jul 13, 2019
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de merged commit 3ff0f87 into fomantic:develop Jul 17, 2019
@lubber-de lubber-de deleted the fix/popup_wrong_default branch July 17, 2019 10:29
@lubber-de lubber-de added this to the 2.7.8 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Correction Anything related to fixing incorrect documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants