fix(transition): transitions made of hidden inline elements were not …

…working anymore
fomantic · Feb 11, 2019 · 0a05e9f · 0a05e9f
1 parent 6216d5f
commit 0a05e9f
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js
@@ -263,9 +263,6 @@ $.fn.transition = function() {
             $module
               .attr('style', overrideStyle)
             ;
-            if(style === '') {
-              $module.removeAttr('style');
-            }
             return true;
           },
           hidden: function() {
@@ -314,22 +311,17 @@ $.fn.transition = function() {
 
         set: {
           animating: function(animation) {
-            // override display if necessary so animation appears visibly
-            if(module.force.visible()) {
-              var
-                  animationClass,
-                  direction
-              ;
-              // remove previous callbacks
-              module.remove.completeCallback();
+            // remove previous callbacks
+            module.remove.completeCallback();
 
-              // determine exact animation
-              animation = animation || settings.animation;
-              animationClass = module.get.animationClass(animation);
+            // determine exact animation
+            animation = animation || settings.animation;
+            var animationClass = module.get.animationClass(animation);
 
               // save animation class in cache to restore class names
-              module.save.animation(animationClass);
+            module.save.animation(animationClass);
 
+            if(module.force.visible()) {
               module.remove.hidden();
               module.remove.direction();