#1607 Apparently commitish doesnt matter, just need to wait at least …

…a second before creating release after push
fomantic · Feb 24, 2015 · 326820f · 326820f
1 parent 27771e2
commit 326820f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/tasks/admin/components/update.js b/tasks/admin/components/update.js
@@ -139,14 +139,15 @@ module.exports = function(callback) {
       console.info('Pushing files for ' + component);
       git.push('origin', 'master', { args: '', cwd: outputDirectory }, function(error) {
         console.info('Push completed successfully');
-        getSHA();
+        setTimeout(createRelease, 1000);
       });
     }
 
-    // gets SHA of last commit for creating release
+    // gets SHA of last commit
     function getSHA() {
       git.exec(versionOptions, function(error, version) {
-        createRelease(version.trim());
+        version = version.trim();
+        console.log(version);
       });
     }
 
@@ -156,7 +157,7 @@ module.exports = function(callback) {
       if(version) {
         releaseOptions.target_commitish = version;
       }
-      github.releases.editRelease(releaseOptions, function() {
+      github.releases.createRelease(releaseOptions, function() {
         nextRepo();
       });
     }

diff --git a/tasks/admin/distributions/update.js b/tasks/admin/distributions/update.js
@@ -134,26 +134,24 @@ module.exports = function(callback) {
 
     // push changes to remote
     function pushFiles() {
-      console.info('Pushing files for ' + component);
+      console.info('Pushing files for ' + distribution);
       git.push('origin', 'master', { args: '', cwd: outputDirectory }, function(error) {
         console.info('Push completed successfully');
-        getSHA();
+        setTimeout(createRelease, 1000);
       });
     }
 
-    // gets SHA of last commit for creating release
+    // gets SHA of last commit
     function getSHA() {
       git.exec(versionOptions, function(error, version) {
-        createRelease(version);
+        version = version.trim();
+        console.log(version);
       });
     }
 
     // create release on GitHub.com
     function createRelease(version) {
       console.log('Tagging release as ', version);
-      if(version) {
-        releaseOptions.target_commitish = version;
-      }
       github.releases.createRelease(releaseOptions, function() {
         nextRepo();
       });