Skip to content

Commit

Permalink
Reverse tab case sensitivity #2455
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Jun 26, 2015
1 parent f19c086 commit 4b14d45
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion RELEASE-NOTES.md
Expand Up @@ -263,7 +263,6 @@
- **Sticky** - Fix issues when `pushing: true` with sticky content having incorrect bottom spacing, when container has bottom padding
- **Sticky** - Fixed issue with sticky content animating width on display in some cases.
- **Tab** - multiple tab groups initialized together with `context: 'parent'` will now each use their own parent
- **Tab** - Tab name is no longer case sensitive
- **Tab** - Tabs now use the standard component design pattern internally
- **Table** - Fixes `sorted` column are not correctly centered with `center aligned` due to margin on sort icon
- **Table** - Fixes `ascending` and `descending` icons were reversed in table
Expand Down
6 changes: 2 additions & 4 deletions src/definitions/modules/tab.js
Expand Up @@ -313,6 +313,7 @@ $.fn.tab = function(parameters) {
;
tabPath = module.utilities.arrayToPath(pathArray);
$.each(pathArray, function(index, tab) {
console.log(tab, tabPath);
var
currentPathArray = pathArray.slice(0, index + 1),
currentPath = module.utilities.arrayToPath(currentPathArray),
Expand Down Expand Up @@ -636,9 +637,6 @@ $.fn.tab = function(parameters) {
if(pathName === undefined) {
pathName = activeTabPath;
}
if(typeof pathName == 'string') {
pathName = pathName.toLowerCase();
}
return typeof pathName == 'string'
? pathName.split('/')
: [pathName]
Expand Down Expand Up @@ -870,7 +868,7 @@ $.fn.tab.settings = {
error: {
api : 'You attempted to load content without API module',
method : 'The method you called is not defined',
missingTab : 'Activated tab cannot be found for this context.',
missingTab : 'Activated tab cannot be found. Tabs are case-sensitive.',
noContent : 'The tab you specified is missing a content url.',
path : 'History enabled, but no path was specified',
recursion : 'Max recursive depth reached',
Expand Down

0 comments on commit 4b14d45

Please sign in to comment.