-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flyout): support short notation $. #2455
Conversation
Also please note, the removed |
Docs added by fomantic/Fomantic-UI-Docs#369. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my little comment 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commited my suggested little change myself, i hope you don't mind
Description
This PR is an adaptation from @lubber-de's #2442.
It adds jquery short notation support (
$.
) to flyout which is made dynamically out of js properties and thus are not bound to an existing dom node.Previously you always had to select body (which still works) when no existing domnode template exists. Infact the body selector was completely ignored.
Before notation (still supported)
After notation