Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] action button has incorrect border radius #1072

Closed
y0hami opened this issue Oct 7, 2019 · 6 comments
Closed

[Dropdown] action button has incorrect border radius #1072

y0hami opened this issue Oct 7, 2019 · 6 comments
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.8.1

Comments

@y0hami
Copy link
Member

y0hami commented Oct 7, 2019

Bug Report

Expected result

Dropdown should not have border radius between the action.

Actual result

Dropdown has border radius as it normally would.

Testcase

https://jsfiddle.net/pxstuqo9/

Screenshot (when possible)

image

Version

2.7.8

Related issues

Semantic-Org/Semantic-UI#5314
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/help-wanted Issues which need help to fix or implement tag/good-first-issue Good issues for new starters to try tag/sui-issue Taken from an existing Issue/PR of SUI Hacktoberfest Issues for Hacktoberfest! labels Oct 7, 2019
@y0hami y0hami added this to the 2.8.0 milestone Oct 7, 2019
@y0hami
Copy link
Member Author

y0hami commented Oct 7, 2019

A good fix to this would be to create a new variation for the dropdown of ui action dropdown which is the same as ui action input but its for the dropdown https://fomantic-ui.com/elements/input.html#action

@Flo4l
Copy link

Flo4l commented Oct 7, 2019

I would like to work on this issue :)

@itsaakashpatel
Copy link

@hammy2899 border-radius: unset property won't do the task?

Thanks!

@y0hami
Copy link
Member Author

y0hami commented Oct 7, 2019

@itsaakashpatel Most likely yes but it would be better to add actions support to dropdown.

RShalman added a commit to RShalman/Fomantic-UI that referenced this issue Oct 7, 2019
@RShalman
Fix [Dropdown] action button has incorrect border radius fomantic#1072
a4682fd
@RShalman RShalman mentioned this issue Oct 7, 2019
Merged
@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Oct 8, 2019
@lubber-de
Copy link
Member

Fixed by #1073
See https://jsfiddle.net/7gf135dc/
@hammy2899 Do you want to open another issue with your dropdown action suggestion (although i think it's not needed now)

@lubber-de lubber-de removed tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement labels Oct 8, 2019
@y0hami
Copy link
Member Author

y0hami commented Oct 9, 2019

@lubber-de I'll just leave it for now since this is technically fixed and the only issue is the class naming isn't semantically correct.

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open Hacktoberfest Issues for Hacktoberfest! labels Oct 31, 2019
@y0hami y0hami closed this as completed in 05df0da Nov 14, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.8.1
Development

No branches or pull requests
4 participants
@y0hami @lubber-de @itsaakashpatel @Flo4l