fix(dimmer): borders on partial segment dimmers are incorrect #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
exoego
reviewed
Dec 15, 2019
y0hami
changed the title
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in #1027 changed the specificity. This lead into the border correction for partial dimmers in segments to not work anymore.
This PR increases their specificity so they are adjusted again.
I also removed the unnecessary
!importantsettings for thesegment > dimmerborder settingsTestcase
Broken corners
https://jsfiddle.net/q1Lfgpk2
Fixed again and
!importantremovedhttps://jsfiddle.net/hq8tcs6w/
Screenshot
Broken
Fixed