Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] searchable dropdown reopens when option is selected #153

Closed
y0hami opened this issue Oct 5, 2018 · 3 comments
Closed

[Dropdown] searchable dropdown reopens when option is selected #153

y0hami opened this issue Oct 5, 2018 · 3 comments
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.6.3

Comments

@y0hami
Copy link
Member

y0hami commented Oct 5, 2018 •
edited
Loading

Bug Report

Steps to reproduce

  1. create a searchable dropdown
  2. search for an option
  3. select an option, use ENTER don't click

Expected result

It should select the option and close

Actual result

It selects the option and reopens the dropdown

Testcase

https://jsfiddle.net/yc7pdzr6/

Version

2.6.2
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Oct 5, 2018
@ColinFrick
Copy link
Member

Regression since version 2.6.1
Probably caused by 4ea71e5

@lubber-de
Copy link
Member

Yes, seems so 😨 I'll take a look

@ColinFrick
Copy link
Member

@lubber-de most likely you just have to check module.is.multiple() before $search.focus();

@lubber-de lubber-de mentioned this issue Oct 5, 2018
Merged
y0hami pushed a commit that referenced this issue Oct 5, 2018
Merge pull request #154 from lubber-de/fix/153
776d6d5 
[Dropdown] Single Selection via keyboard gained focus again Fixes #153
@y0hami y0hami added this to the 2.6.3 milestone Oct 5, 2018
@y0hami y0hami mentioned this issue Oct 17, 2018
Merged
@y0hami y0hami closed this as completed in a7c7c29 Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.3
Development

No branches or pull requests
3 participants
@ColinFrick @y0hami @lubber-de