Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Group of disabled basic button not properly display #643

Closed
dutrieux opened this issue Apr 8, 2019 · 1 comment
Closed

[Button] Group of disabled basic button not properly display #643

dutrieux opened this issue Apr 8, 2019 · 1 comment
Assignees
@dutrieux
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.5

Comments

@dutrieux
Copy link
Contributor

dutrieux commented Apr 8, 2019 •
edited
Loading

Bug Report

Group of disabled basic button not properly display

Expected result

each button of group need to be have box-shadow

Actual result

Testcase

https://jsfiddle.net/dutrieux/5qw3nkb0/5/

Screenshot (when possible)

image

Version

2.7.4
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Apr 8, 2019
@y0hami
Copy link
Member

y0hami commented Apr 8, 2019

I think we should also add ui.disabled.buttons as an option.

@dutrieux dutrieux changed the title Group of disabled basic button not properly display [Button] Group of disabled basic button not properly display Apr 8, 2019
@dutrieux dutrieux mentioned this issue Apr 8, 2019
Merged
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 9, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 11, 2019
exoego pushed a commit to exoego/Fomantic-UI that referenced this issue Apr 30, 2019
@dutrieux
fix(button): group of basic disabled buttons had incorrect styles
26f3024 
Group of **disabled basic** button not properly display

Closes fomantic#643
@y0hami y0hami closed this as completed in 7f63e50 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dutrieux dutrieux

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

No branches or pull requests
3 participants
@dutrieux @y0hami @lubber-de