Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Font Awesome to 5.9.0 #887

Closed
mrcasablr opened this issue Jul 20, 2019 · 2 comments
Closed

Upgrade Font Awesome to 5.9.0 #887

mrcasablr opened this issue Jul 20, 2019 · 2 comments
Assignees
@y0hami
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone
2.7.7

Comments

@mrcasablr
Copy link

Font Awesome 5.9.0 - https://fontawesome.com/changelog/latest has new icons
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS labels Jul 20, 2019
@lubber-de
Copy link
Member

@hammy2899 When you do this, please consider, if the order of the icon css can be adjusted, to fix the following bug #739 (comment)

@Bradley-H
Copy link

Perhaps I'm just a bit of a purist, but lets just make our own icons with .svg's. I'm sure it'll be a bunch of work, but I would (like anyways) to seperate us from the bunch and not have to rely on 3rd parties.

y0hami pushed a commit that referenced this issue Jul 28, 2019
feat(icons): update icons to FA 5.9.0
9f17f00 
Also fixes an issue with "angle down" icons described in #739

Closes #887, #739
@y0hami y0hami mentioned this issue Jul 28, 2019
Closed
@y0hami y0hami closed this as completed in dfc9109 Jul 28, 2019
@exoego exoego added this to the 2.7.7 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y0hami y0hami

Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.7
Development

No branches or pull requests
5 participants
@exoego @y0hami @lubber-de @mrcasablr @Bradley-H