[Calendar] new option autoAdjustDateEdges avoid invalid mindate/maxdate combinations #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
exoego
reviewed
Mar 14, 2020
|
@fomantic/maintainers Before reviewing, please take a look at the conversion in the original issue #1364 (comment) |
ColinFrick
previously approved these changes
Mar 25, 2020
lubber-de
added
the
state/on-hold
lubber-de
removed
the
state/awaiting-reviews
# Conflicts: # src/definitions/modules/calendar.js
# Conflicts: # src/definitions/modules/calendar.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new setting
autoAdjustDateEdges(defaultfalseto stay backward compatible)When enabled and a call to
set.minDateorset.maxDatewould result in an invalid range (min > max or max < min) it will automatically set the opposite edge to the same value, so the range stays valid.The current (and still default) behavior already fetches invalid values but only shows this in the log when debug and verbose is enabled, so fails silently. As this is rather an error than a verbose information i also changed the log level to error in those cases.
Testcase
https://jsfiddle.net/k386q42s/1/
Closes
#1364