[dropdown] Fix a sizer element being created every time dropdown is initialized #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
lubber-de and
prudho
lubber-de
added
lang/javascript
lubber-de
approved these changes
Jun 2, 2020
lubber-de
added
tag/next-release/nightly
lubber-de
removed
the
tag/next-release/nightly
|
@all-contributors please add @ryamaguchi0220 for code |
|
@ryamaguchi0220 already contributed before to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that a dropdown has only one sizer element no matter how many times it is initialized.
It looks like
!module.has.sizer()of this line already ensures it, but actually does not.$sizer.length > 0insidehas.sizer()always returnsfalsebecausesizer.selectoris> input.sizereven though the sizer element is created asspanelement (I think> span.sizeris needed instead of> input.sizer).I'm not 100% sure whether this is a bug, so feel free to close this PR if anything is wrong.
Testcase
Both test cases initialize the dropdown twice.
Try to see how many sizer elements are created via your developer tool.
Broken
https://jsfiddle.net/c5oz8fhk/
Fixed
https://jsfiddle.net/yz8ptx21/
Closes
no-issue