[Button] compact icon button had wrong padding #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
lubber-de
added a commit
that referenced
this pull request
Dec 3, 2020
A labeled icon button got a wrong margin especially when used for multiple dropdown buttons as the specificity changed in #1571 However labeled icon buttons are never supposed to be displayed without text so the selector for single icon buttons should not select labeled buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
compact icon buttonpadding was overridden by the usual padding because of too low specifitiyTestcase
Broken
https://jsfiddle.net/lubber/ad2m4gqv/1/
Fixed
https://jsfiddle.net/lubber/ad2m4gqv/2/
Screenshot
Watch the middle Pause button
Broken
Fixed
Closes
#1582