Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdown): support inverted menu in non-inverted dropdown #1793

Merged
merged 1 commit into from
Dec 17, 2020
Merged

feat(dropdown): support inverted menu in non-inverted dropdown #1793

merged 1 commit into from
Dec 17, 2020

Conversation

lubber-de
Copy link
Member

Description

In cases where you want to use an inverted dropdown menu, without having the dropdown being inverted itself, this wasnt possible.

Especially when one uses menus with dropdown buttons inside, this was not supported.

This PR now allows to have an inverted menu inside a non-inverted dropdown.

Testcase

  • The left button is a non-inverted dropdown but uses an inverted menu
  • The right button is an inverted dropdown as usual

Before

After

Screenshots

Before

image

After

image

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 15, 2020
@lubber-de lubber-de added this to the 2.8.8 milestone Dec 15, 2020
exoego
exoego approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ko2in
ko2in approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lubber-de lubber-de added state/awaiting-docs Pull requests which need doc changes/additions and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 17, 2020
@lubber-de lubber-de merged commit 46a91bb into fomantic:develop Dec 17, 2020
@lubber-de lubber-de deleted the feat/1788/dropdownInvertedMenu branch December 17, 2020 09:08
@lubber-de lubber-de mentioned this pull request Dec 25, 2020
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Dec 25, 2020
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@ko2in ko2in ko2in approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.8.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lubber-de @exoego @ko2in @ColinFrick