fix(flag): ensure unique flag and a-z class names #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
requested review from
exoego,
ko2in,
ColinFrick,
prudho and
y0hami
mvorisek
reviewed
Sep 25, 2022
| aliasClass: false; | ||
| aliasClass2: false; | ||
| }; | ||
| @1f3f3-fe0f-200d-1f308: { | ||
| countrycode: rainbow; | ||
| class: rainbow; | ||
| aliasClass: gay_pride; | ||
| class: gay_pride; |
There was a problem hiding this comment.
any idea why this generated i.flag.gay.pride::before selector? (not tested this exact PR, notice the . instead of _)
There was a problem hiding this comment.
Because the code assumes an underscore to be a word/classname split. (Same for "cayman_islands") following the original idea of SUI to have "spoken sentence words as classnames"
However, i just named it "pride" and added another alias LGBT instead by bb32817 according to https://emojiterra.com/rainbow-flag/ or https://emojipedia.org/rainbow-flag/
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Sep 25, 2022
removed some unsupported emojis and flag renaming as of fomantic/Fomantic-UI#2466 and fomantic/Fomantic-UI#2464
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
#2357 (comment)