Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): fix lighthouse warning #2519

Merged
merged 1 commit into from Oct 24, 2022

Conversation

lubber-de
Copy link
Member

Description

the icon fonts need font-display to eliminate lighthouse warning in devtools
Fontaweseome did this themselves by FortAwesome/wordpress-fontawesome#110

Screenshots

image

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 22, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Oct 22, 2022
@exoego
Copy link
Contributor

exoego commented Oct 22, 2022

lubber-de added a commit to fomantic/create-fomantic-icons that referenced this pull request Oct 24, 2022
the icon fonts need font-display to eliminate lighthouse warning in devtools
Fontaweseome did this themselves by FortAwesome/wordpress-fontawesome#110

## Related FUI PR
fomantic/Fomantic-UI#2519
@lubber-de lubber-de merged commit d199521 into fomantic:develop Oct 24, 2022
@lubber-de lubber-de deleted the iconLighthouse branch October 24, 2022 11:21
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants