[Sidebar] Respect a change of closable setting

[lubber-de]

Description

The closable setting is ignored in sidebar when the setting was changed after initialization.

Testcase

• Keep the red sidebar open
• Click on "Fix sidebar"
• Click on "Toggle sidebar"
  -> Sidebar should not close

Unfixed (original SUI issue)

https://jsfiddle.net/r7fws0nn

Fixed

https://jsfiddle.net/r7fws0nn/23/

Closes

Semantic-Org/Semantic-UI#5329

[y0hami]

LGTM

[ColinFrick]

The other way around doesn't work either. If you set closable to false, open it, then set closable to true from inside the sidebar doesn't bind the clickaway events:

Fomantic-UI/src/definitions/modules/sidebar.js

Lines 176 to 184 in b318944

	clickaway: function() {
	module.verbose('Adding clickaway events to context', $context);
	if(settings.closable) {
	$context
	.on('click' + elementNamespace, module.event.clickaway)
	.on('touchend' + elementNamespace, module.event.clickaway)
	;
	}
	},

https://jsfiddle.net/Korinu/5obdax1z/

[lubber-de]

@ColinFrick Then i suggest to always bind the clickaway events, regardless of the closable setting, just because the closable setting is centrally fetched in the hide function. Agree?

[lubber-de]

@ColinFrick As suggested, the clickaway is now bound in any case. This was the easiest (in my pov cleanest) solution. otherwise i had to bind/unbind the clickway every time the closable settings changes and i feared other bugs then.

[ColinFrick]

That’s fine

LGTM

[y0hami]

LGTM