[Sidebar] Make closable only work in clickaway event as stated in the docs #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a misunderstood meaning of
closable
implemented in #335The
closable
setting should only have effect on clickAway events, but a sidebar should be closable all the time when triggered via any behavior call as stated in the docs.Testcase
Broken
... it does not close
http://jsfiddle.net/xqtb1pw0
Fixed
.. it does (but does not when clicking in the pusher area as expected)
http://jsfiddle.net/pw2xfs3v/
Closes
#467