Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] correct tooltip z-index value #395

Merged
merged 1 commit into from
Jan 16, 2019
Merged

[Popup] correct tooltip z-index value #395

merged 1 commit into from
Jan 16, 2019

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Jan 14, 2019

Description

Changed the tooltip z-index to be the same as standard popup which forces it to appear on top of other components such as sticky elements.

Testcase

https://jsfiddle.net/95f1wmL8/

Screenshot (when possible)


image

Closes

#394

@y0hami y0hami added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Jan 14, 2019
@y0hami y0hami added this to the 2.7.x milestone Jan 14, 2019
@y0hami y0hami self-assigned this Jan 14, 2019
@y0hami y0hami mentioned this pull request Jan 14, 2019
Closed
lubber-de
lubber-de approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 44a1fbe into develop Jan 16, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 16, 2019
@y0hami y0hami deleted the fix/tooltip-zindex branch January 16, 2019 12:37
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 16, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@lubber-de lubber-de lubber-de approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees

@y0hami y0hami

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@y0hami @ColinFrick @lubber-de @exoego