Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Increased color specificity to override secondary menu default colors #409

Merged

Conversation

lubber-de
Copy link
Member

Description

using a secondary pointing menu together with a color was still showing the default colors of a secondary menu because of too low specificity

Testcase

https://jsfiddle.net/uvg6e4af/
Remove CSS to see issue

The fiddle cointains the inverted variant aswell which also includes the fixes from #380

Screenshot

Before

image

After

image

Closes

#406

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 17, 2019
@lubber-de lubber-de added this to the 2.7.2 milestone Jan 17, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 99702cf into fomantic:develop Jan 17, 2019
@lubber-de lubber-de deleted the fix/406/color_specificity_secondary branch January 17, 2019 15:01
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 17, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants