[Menu] Wrong Border for inverted pointing menu removed and fix for secondary as color #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tted secondary as color for inverted menus
lubber-de
added
lang/css
lubber-de
deleted the
fix/4952/secondary_pointing_menu_border_background
branch
lubber-de
removed
the
state/awaiting-reviews
Merged
exoego
added
type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An
inverted secondary pointing menuhad a border set around the whole menu instead of only at the bottom as in the non-inverted variant. This was definately wrong (copy/paste) behavior, because the border-color class was doubled and had the non-inverted variable@secondaryPointingBorderColorinstead of@secondaryPointingInvertedBorderColorset (which is again done one class definition later)I guess in those (probably rarely used) cases where this combination was used, it was used with a black background, where the border was very hard to recognize. In a whole: It simply looked wrong and inconsistent to the non-inverted variant.
Additionally I also fixed the missing
invertedcolor loop to omit thesecondaryvalue just like in #366 becausesecondaryis used with a different meaning inmenuTestcase
http://jsfiddle.net/efp8z6Ln/952/
Remove the CSS to see the previous behavior.
Screenshot
Before
After
Closes
Semantic-Org/Semantic-UI#4953