[Modal] Reactivate approve/deny event handling if onHide returned false #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
onDenyandonApproveevents were only called once and never again, in caseonHidereturned false preventing the modal to be closed.I decided against calling the given callback function (which would have fixed it in that case also), but the callback is basically unknown in general and
hidecould also be called as a behavior from outside where probably given callbacks are not supposed to be called also in case the modal was denied to be closed.Testcase
Broken
https://jsfiddle.net/0sqk6yhx/
Fixed
https://jsfiddle.net/7gs90uqc/
Closes
Semantic-Org/Semantic-UI#5558