Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Inverted success/warning/error progress bars had no color #483

Merged
merged 1 commit into from Feb 20, 2019
Merged

[Progress] Inverted success/warning/error progress bars had no color #483

merged 1 commit into from Feb 20, 2019

Conversation

lubber-de
Copy link
Member

Description

Because of too low specificity the states success,warning and error for inverted progress had only the default gray color set overriding their respective colors

Testcase

Remove CSS to see issue
https://jsfiddle.net/rhvqno2z/

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Feb 12, 2019
@lubber-de lubber-de added this to the 2.7.3 milestone Feb 12, 2019
y0hami
y0hami approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 90057fa into fomantic:develop Feb 20, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 20, 2019
@lubber-de lubber-de deleted the fix/progress_inverted_state_color_specificity branch February 20, 2019 14:21
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lubber-de @ColinFrick @y0hami @exoego