Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] initialDate now update input #559

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[Calendar] initialDate now update input #559

merged 1 commit into from
Mar 12, 2019

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Mar 11, 2019

Description

This PR fixes the no displayed date despite user has set initialDate. It also fixes an error when a non standard date was given trough metadata.

Closes

#549

@prudho prudho added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Mar 11, 2019
@prudho prudho added this to the 2.7.3 milestone Mar 11, 2019
lubber-de
lubber-de approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prudho prudho mentioned this pull request Mar 11, 2019
Closed
ColinFrick
ColinFrick approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 12, 2019
@y0hami y0hami merged commit 7e30c28 into fomantic:develop Mar 12, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@lubber-de lubber-de mentioned this pull request Apr 2, 2019
Merged
@prudho prudho deleted the fix-549 branch April 11, 2019 13:00
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prudho @ColinFrick @lubber-de @exoego @y0hami