Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements: [Dropdown] Possibility to select adjacent month dates. #562

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Enhancements: [Dropdown] Possibility to select adjacent month dates. #562

merged 2 commits into from
Mar 19, 2019

Conversation

patilkiranm
Copy link
Contributor

Description

The calendar can show dates from adjacent months. These adjacent month dates can also be made selectable.

Option: selectOtherMonths boolean defaults to false

Screenshot


selectothermonths

@patilkiranm
Enhancements: [Dropdown] Possibility to select adjacent month date se…
31dcf8f 
…lection.

Option: selectOtherMonths boolean defaults to false

The calendar can show dates from adjacent month. These adjacent month dates can also be made selectable.
lubber-de
lubber-de reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think renaming the option to selectAdjacentDays fits better

lubber-de
lubber-de requested changes Mar 11, 2019
View reviewed changes
src/definitions/modules/calendar.less Outdated Show resolved Hide resolved
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/awaiting-docs Pull requests which need doc changes/additions labels Mar 11, 2019
@patilkiranm
Enhancements: [Dropdown] Possibility to select adjacent month date se…
8f44929 
…lection.

Option: selectAdjacentDays boolean defaults to false

The calendar can show dates from adjacent month. These adjacent month dates can also be made selectable.
@patilkiranm
Copy link
Contributor Author

I think renaming the option to selectAdjacentDays fits better

Updated PR: option name changed from selectOtherMonths to selectAdjacentDays

@patilkiranm patilkiranm marked this pull request as ready for review March 12, 2019 06:45
lubber-de
lubber-de approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.7.3 milestone Mar 13, 2019
@lubber-de
Copy link
Member

lubber-de commented Mar 13, 2019 •
edited
Loading

As it is so far approved by @hammy2899 and me i added this to 2.7.3
@prudho @ColinFrick Feel free to change to 2.7.4 if you disagree

@lubber-de lubber-de mentioned this pull request Mar 17, 2019
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Mar 17, 2019
prudho
prudho approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit e21a158 into fomantic:develop Mar 19, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@y0hami
Copy link
Member

y0hami commented Aug 27, 2019

@all-contributors please add @patilkiranm for code

@allcontributors allcontributors bot mentioned this pull request Aug 27, 2019
Merged
@allcontributors
Copy link
Contributor

@hammy2899

I've put up a pull request to add @patilkiranm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@y0hami y0hami y0hami approved these changes

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@patilkiranm @lubber-de @y0hami @prudho