[Dimmer] Loader inside simple inverted dimmer was still visible even when parent was not dimmed #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(a possible loader inside was still visible)
lubber-de
added
type/bug
y0hami
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the docs, a
simple dimmershould completely hide all of its content when the parent element is notdimmedUnfortunately a possible loader inside the dimmer was still shown and got especially visible when used in a
simple inverted dimmerTestcase
https://jsfiddle.net/2Lgukfc0/
Remove CSS to see the issue
Closes
Semantic-Org/Semantic-UI#6257