Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Columnar dropdown variation #586

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Mar 25, 2019

Description

This PR adds columnar variation to dropdown module like two column dropdown in the same manner as two column grid, so that more items can be glanced at once.
This is helpful if dropdown have tons of items (e.g. Countries, States/Providences, Divisions, something like that).

Numbers of columns can vary between 2 (50% for each item) and 5 (20% for each).

Screenshot (when possible)

Standard dropdown of 2 columns

standard-two-col

Fluid search dropdown of 3 columns

fluid-search-three-col

Closes

Related to #545 (taller dropdown) but different approach and different use-case .

@exoego exoego changed the base branch from master to develop March 25, 2019 01:49
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 25, 2019
@lubber-de lubber-de added this to the 2.7.4 milestone Mar 25, 2019
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🙂 Surprisingly simple but very effective solution. Thanks for contributing again
LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ! LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 25, 2019
@y0hami y0hami modified the milestones: 2.7.4, 2.7.3 Mar 25, 2019
@lubber-de lubber-de added the state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo label Mar 25, 2019
@y0hami y0hami merged commit fc437cb into fomantic:develop Mar 26, 2019
@exoego exoego deleted the columnar-dropdown branch March 26, 2019 08:19
y0hami pushed a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Mar 26, 2019
Add new content for columnar dropdown proposed in fomantic/Fomantic-UI#586
y0hami pushed a commit that referenced this pull request Mar 26, 2019
This PR adds height variation to dropdown module so that more items can be glanced at once.
This is helpful if dropdown have tons of items (e.g. Countries, States/Providences, Divisions, something like that).

This is usable if every items can be shown at once within the height of window without scroll bar.
If there are so many items that requires scroll bar, user can consider columnar variation proposed in #586.

Closes #545
@y0hami y0hami mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants