-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] Columnar dropdown variation #586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🙂 Surprisingly simple but very effective solution. Thanks for contributing again
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat ! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add new content for columnar dropdown proposed in fomantic/Fomantic-UI#586
This PR adds height variation to dropdown module so that more items can be glanced at once. This is helpful if dropdown have tons of items (e.g. Countries, States/Providences, Divisions, something like that). This is usable if every items can be shown at once within the height of window without scroll bar. If there are so many items that requires scroll bar, user can consider columnar variation proposed in #586. Closes #545
Description
This PR adds columnar variation to dropdown module like
two column dropdown
in the same manner astwo column grid
, so that more items can be glanced at once.This is helpful if dropdown have tons of items (e.g. Countries, States/Providences, Divisions, something like that).
Numbers of columns can vary between 2 (
50%
for each item) and 5 (20%
for each).Screenshot (when possible)
Standard dropdown of 2 columns
Fluid search dropdown of 3 columns
Closes
Related to #545 (taller dropdown) but different approach and different use-case .