Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): open animation broken on first open #698

Merged
merged 1 commit into from
Apr 26, 2019
Merged

fix(modal): open animation broken on first open #698

merged 1 commit into from
Apr 26, 2019

Conversation

dutrieux
Copy link
Contributor

Description

To fix the issue 542

Testcase

https://jsfiddle.net/dutrieux/ajwfetgh/76/

Closes

#542

@lubber-de lubber-de changed the base branch from master to develop April 26, 2019 06:57
lubber-de
lubber-de approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews lang/javascript Anything involving JavaScript labels Apr 26, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 26, 2019
y0hami
y0hami approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exoego
exoego approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Apr 26, 2019
@y0hami y0hami changed the title Fix 542 animation broken modal dropdown multiple fix(modal): open animation broken on first open Apr 26, 2019
@y0hami y0hami merged commit 353f90f into fomantic:develop Apr 26, 2019
@dutrieux dutrieux deleted the fix-542_animation_broken_modal_dropdown_multiple branch April 26, 2019 17:48
This was referenced May 17, 2019
Merged
Closed
y0hami pushed a commit that referenced this pull request May 17, 2019
@lubber-de
fix(transition): not checking for event object lead to TypeError
0c56c8d 
This PR fixes a regression of #698 where it was not covered that the completemethod could have been called outside of an event, thus the event object was not available and accessing it lead into a TypeError

Closes #745
@y0hami
Copy link
Member

y0hami commented Aug 27, 2019

@all-contributors please add @dutrieux for code

@allcontributors allcontributors bot mentioned this pull request Aug 27, 2019
Merged
@allcontributors
Copy link
Contributor

@hammy2899

I've put up a pull request to add @dutrieux! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@lubber-de lubber-de lubber-de approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dutrieux @y0hami @exoego @ColinFrick @lubber-de