fix(progress): wrong error on validating sum of rounded percents #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
lubber-de and
prudho
lubber-de
added
state/awaiting-reviews
prudho
approved these changes
Aug 26, 2019
y0hami
removed
the
state/awaiting-reviews
y0hami
changed the title
|
@all-contributors please add @ryamaguchi0220 for code and bug |
|
@hammy2899 I've put up a pull request to add @ryamaguchi0220! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose to store unrounded percents in the
data-percentattribute instead of rounded percents.Here is what causes the wrong error.
① Store rounded percents in the
data-percentattribute here② Get the rounded percents here
③ Validate sum of the rounded percents here.
As this comment indicates, it is not expected to pass rounded percents to the
percent().Testcase
https://jsfiddle.net/yxLr6mut/
Closes
#953