Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Notify when done" checkbox can't be checked #2809

Closed
yha opened this issue Feb 12, 2024 · 5 comments
Closed

The "Notify when done" checkbox can't be checked #2809

yha opened this issue Feb 12, 2024 · 5 comments

Comments

@yha
Copy link
Contributor

yha commented Feb 12, 2024

When checking it, it immediately unchecks.
out
This video is on Edge on Windows. Also observed on Firefox and Chrome.

@fonsp
Copy link
Owner

fonsp commented Feb 14, 2024

Can you check your notification settings for this site (localhost:1234), for your browser, and your OS? Are you able to receive OS notifications from other sites?

Edge support page: https://support.microsoft.com/en-us/microsoft-edge/manage-website-notifications-in-microsoft-edge-0c555609-5bf2-479d-a59d-fb30a0b80b2b

@fonsp
Copy link
Owner

fonsp commented Feb 21, 2024

@yha Did this resolve your issue?

@fonsp fonsp closed this as completed in 15962d6 Feb 21, 2024
@fonsp
Copy link
Owner

fonsp commented Feb 21, 2024

I made 15962d6 which should make this situation more clear for other users :)

@yha
Copy link
Contributor Author

yha commented Mar 3, 2024

Can you check your notification settings for this site (localhost:1234)

Actually, I'm not running pluto on localhost, but on a server on a local network. Probably should have mentioned that, sorry for the confusion.
When running Pluto locally, the notification works. Remotely still doesn't work.
I tried it now with the new Pluto version. I have notifications enabled for the server's address, but the checkbox won't change state and I get the new error message. On Edge and Chrome, when I try to enable notifications more specifically for http://+address it refuses because it's not secure (Firefox allows setting it, but the notifications still don't work). So perhaps the insecure connection is the issue? Is there a way to serve Pluto over https?

@ctrekker
Copy link
Collaborator

ctrekker commented Mar 4, 2024

You're correct, browsers generally don't permit notifications from insecure contexts (see this MDN page).

Pluto doesn't support HTTPS hosting by itself since there are better tools to do this anyways. To my knowledge the best way to host Pluto in a secure context is with a reverse proxy like NGINX, but this requires lots of extra setup, not to mention the difficulties of actually getting an SSL certificate signed so browsers will accept a secure connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants