-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build FontForge git master with Homebrew #1344
Comments
Homebrew needs to be updated at approx line 99. See issue #1366 |
What's the status of this? |
These should be gone since they are put in the config directory, which
These warning should be gone.
As for the homebrew formula, a suggestion has been posted in #1366 which NOTE the ./bootstrap and ./autogen.sh (homebrew if/then/else) is a seperate |
@monkeyiq please look into this :) |
A few general "brew" questions. For me the above brew install line from Dave's original post tries to build without using X. This may be that my brew is set to not use X? If I use the below then I get a GUI:
And is there anything needed to 'select' the python that brew has installed. By default fontforge doesn't find that python's pc file so will fail to build. I have a work around for that, but thought I'd ask in case there is already some work around in brew. As brew seems to set PKG_CONFIG_PATH to various subdirectories for you, but not the python one. |
Did you look at Homebrew/legacy-homebrew#27221 ? I think if you have done 'brew install python' already then the build will find the pc files. Do you have this, https://github.com/Homebrew/homebrew/wiki/Homebrew-and-Python#technical-details ? |
Hmm adding some python deps to the brew file doesn't seem to resolve things right off the bat. I notice that python-config is then in the path and might work, but fontforge looks to use pkg-config to do the magic. I'll have a look at a work around.
|
ok I have something for the python issue now. next up is to fix that git/gnulib issue (top post) in a more permanent way. |
AHA!! :) http://docs.travis-ci.com/user/osx-ci-environment/ We can now test that FontForge builds with HomeBrew for each pull request via Travis!! |
I updated the top of the issue to list out the goals |
Still need to fix something in fontforge.rb |
@dave does it build for you now using Homebrew/legacy-homebrew#31226 |
Current Pull Request for point #2 is at Homebrew/legacy-homebrew#31226 |
@monkeyiq yes, that :) Found a small bug with the About window, will report a new issue for it. |
@monkeyiq is the working formula merged into Homebrew upstream? And does the formula now build the FontForge.app bundle? |
@davelab6 Looks like it was merged in this commit. And yes, an app bundle is being built, but isn't symlinked into /Applications due to the slightly unusual placement of that app bundle. |
In fact, symlinking into ~/Applications doesn't work at all. Fontforge refuses to launch from the .app bundle compiled from source. Hmm. The only way to launch it is to execute |
The bundle needs to be in /Applications. |
Homebrew doesn't directly install anything into /Applications. It symlinks from |
HB can build a FontForge bundle in ~/Appplications and when the user runs it, it will say 'move me to /Applications' and quit. Will that be ok? |
@monkeyiq there are 2 oustanding tasks in the top:
Are those done? |
We don't directly build anything in /Applications. Even Homebrew-Cask doesn't directly install there. Everything is done via symlinks, ie, in this case we'd move the app bundle out of its current prefix & into the main installation folder (In this case, usually |
It doesn't work symlinked today: However, if I remove the check at https://github.com/fontforge/fontforge/blob/master/osx/FontForge.app/Contents/MacOS/FontForge#L13-L23 :
it runs! So @monkeyiq please update the check so that if you move the app to /tmp and symlink it, it passes this shell script test. Then I hope @DomT4 can adjust the homebrew receipe to symlink to the app bundle it builds in |
@DomT4 good news, @monkeyiq has made the change - https://github.com/fontforge/fontforge/pull/1808/files#diff-0 |
This and an earlier issue are in 201410/17_1506 |
Yup. This is easily enough done once we get a successful build inside Homebrew. |
@DomT4 do we now have a successful build? |
Okay great! So the remaining task on this issue is for @monkeyiq to change from a "macbook-air-built, macports-based daily build to upload to fuuko" to "macbook-air-built homebrew-based daily build uploaded to bigv" This should help to ensure that we keep |
For any urgent fixes, ie fixing the dylib issue, fixing the issue in #1838, etc I'll very probably port those backwards to the stable build in Homebrew. Just shout if you need anything and I'll do my best. |
Nah, lets just make a new release next week |
Alright, Will keep an eye out. I'll keep fingers crossed the dylib issue is solved by that point and I can turn collab back on by default, but if a week is too soon I'll just leave that out as an option instead again. |
@DomT4 dynlib is solve :) |
@davelab6 Cheers Dave. I could use a release here to nicely wrap up all the changes made in the last week or so if possible? There's probably way too much to backport at this point without ensuring nobody ever wants to maintain the Homebrew formula ever again, heh. |
Travis OS X still fails FWIW… e.g. https://travis-ci.org/fontforge/fontforge/jobs/39176945 |
^^ It appears to ship 4 dependencies that Homebrew's formula doesn't. Is that an issue? The Travis build is waaaay behind Homebrew's though, even with your custom modifications to make life easier on Travis the script it is using is at least 2 or 3 versions behind Homebrew's. |
The current Homebrew formula with the current Fontforge git head works:
|
I think Travis installs their own easy_install and pip, so its failing on |
If Python is already on the system and stored in /usr/bin or /usr/local/bin you should be able to trim the Python dependency from the formula and make it pass Travis that way. |
But will ff python work that way?
|
Should do, if you're building from source each time. It might be worth passing the |
fontforge.rb
recipeGet Travis CI to push this travis-made FontForge.app bundle to the(cancelled as Travis is too puny)bigv.io
serverChange "macbook-air-built, macports-based daily build to upload to fuuko" to "macbook-air-built homebrew-based daily build uploaded to bigv"(cancelled as not important)I am trying to compile FontForge with Homebrew, and the formula hasn't been updated for the
bootstrap
stuff... any tips? :)The text was updated successfully, but these errors were encountered: