Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

fontforge: Update formula for 2.0 #27221

Closed
wants to merge 1 commit into from
Closed

fontforge: Update formula for 2.0 #27221

wants to merge 1 commit into from

Conversation

spl
Copy link
Contributor

@spl spl commented Mar 5, 2014

An improved version of #27220.

@adamv
Copy link
Contributor

adamv commented Mar 5, 2014

Does the built software seem to work OK?

adamv
adamv reviewed Mar 5, 2014
View reviewed changes
Library/Formula/fontforge.rb
end

option 'with-gif', 'Build with GIF support'
option 'with-x', 'Build with X11 support, including FontForge.app'
depends_on :autoconf => :build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> :build is implicit in these three symbol deps, so can be removed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On autoconf, automake, and libtool? OK.

@adamv
Copy link
Contributor

adamv commented Mar 5, 2014

Thanks for tackling this.

@adamv adamv mentioned this pull request Mar 5, 2014
Closed
@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

Yes, I think FontForge seems to work OK.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

How should formulas link into /Applications?

@MikeMcQuaid
Copy link
Member

Just install into prefix and people will be prompted to use brew linkapps.

@adamv
Copy link
Contributor

adamv commented Mar 5, 2014

They shouldn't; the .app should be left in the prefix and then brew linkapps will find it and make a symlink.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

Currently, the .app is being installed by make install into $prefix/share/fontforge_package_name/osx/FontForge.app.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

Updated to use more double quotes.

@adamv
Copy link
Contributor

adamv commented Mar 5, 2014

We can add prefix.install share/"fontforge_package_name/osx/FontForge.app" to move the app (if I got the path correct.)

@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

Excellent. I was hoping there was an easy way. I'll try it.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2014

Hmm. I've updated the implicit :build deps and added the prefix.install. But I can't open the .app at all now. I'm certain it's not related to these changes. I've uninstalled and reinstalled several times. I don't know where FontForge.app keeps its settings, but maybe something is killing it.

@adamv
Copy link
Contributor

adamv commented Mar 6, 2014

I'll pull this leaving the app in its share location for now.

@adamv
Copy link
Contributor

adamv commented Mar 6, 2014

Thinking about this, doesn't the App need X11 support? The default is to build without it.

@adamv
Copy link
Contributor

adamv commented Mar 6, 2014

I think "LSOpenURLsWithRole() failed with error -10810" means it couldn't access the UI.

@adamv
Copy link
Contributor

adamv commented Mar 6, 2014

Enabling X didn't help.

@adamv
Copy link
Contributor

adamv commented Mar 6, 2014

Doesn't run from the share location either.

@spl
Copy link
Contributor Author

spl commented Mar 6, 2014

Well, I ran it before from its default make install location. Yes, I've been using --with-x to install. I left it as an (unrecommended) option because that's how the formula had it. I suppose we don't want to force somebody to require :x11 if we don't have to. However, I'd guess that the common use case would be as an .app.

I'll look into again later, maybe this weekend. Where did you see "LSOpenURLsWithRole() failed with error -10810"?

@adamv
Copy link
Contributor

adamv commented Mar 7, 2014

I got the error opening the app from the command line.

If I double-click the app in finder nothing happens for me.

@baskerville
Copy link
Contributor

FontForge.app assumes to be in /Applications.

The problem comes from some hard-coded paths in the FontForge.app/Contents/MacOS/FontForge script.

@spl
Copy link
Contributor Author

spl commented Apr 25, 2014

@baskerville When I tried it (which, granted, was a long time ago), the built FontForge.app worked the first time but not thereafter. I don’t remember if I put it in /Applications the first time, but I know I tried in /Applications and elsewhere after that.

Did you try the formula in this pull request? I kind of gave up on it, and I don't follow the FontForge development progress. But I would still like to have the latest and greatest.

@adamv
Copy link
Contributor

adamv commented Apr 25, 2014

I definitely wasn't running it out of /Applications.

@adamv adamv self-assigned this Apr 25, 2014
@adamv adamv removed their assignment May 21, 2014
@adamv adamv mentioned this pull request May 27, 2014
Closed
@adamv
Copy link
Contributor

adamv commented Jul 23, 2014

This needs to be rebased on master.

@davelab6 davelab6 mentioned this pull request Jul 28, 2014
Closed
7 tasks
@davelab6
Copy link
Contributor

davelab6 commented Aug 1, 2014

I think this is replaced with #31226 ?

@davelab6
Copy link
Contributor

I suggest closing this issue

@adamv adamv closed this Aug 18, 2014
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spl @adamv @MikeMcQuaid @baskerville @davelab6